-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This should also bump one or both of the version numbers. @camilleanne how about setting the user agent to |
@friedbunny could you post an example of what each of the new events will look like? I'm having a hard time reading through all this quickly. Also, yes, the version numbers should bump. When will they go live? I would need to set up validation in api-events for a v2 |
@camilleanne Sure, I'll get you JSON. This will go live in a couple weeks when v3.1.0 is released. |
b2b2c72
to
6ca1ca5
Compare
6ca1ca5
to
db7fc52
Compare
@@ -1474,15 +1466,11 @@ - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecogni | |||
return ([validSimultaneousGestures containsObject:gestureRecognizer] && [validSimultaneousGestures containsObject:otherGestureRecognizer]); | |||
} | |||
|
|||
- (void)trackGestureEvent:(NSString *)gestureID forRecognizer:(UIGestureRecognizer *)recognizer | |||
- (void)trackGestureEvent:(NSString *)gestureID forRecognizer:(__unused UIGestureRecognizer *)recognizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this parameter is unused, just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- remove `instance` - remove `bundleId` - make `pushEnabled` a private method - remove `lat`,`lng` from interaction events - remove obsolete `enabled.email` key
db7fc52
to
e33e58f
Compare
e33e58f
to
5a1325d
Compare
Updates:
In general, because so much has moved on in mapview and events, this PR should probably serve as a reference and we can cherry pick in the still relevant parts to a fresh branch. |
Subsumed by #4164 |
pluggedIn
key to non-location eventsenabled.telemetry
key to turnstile (supercedes Add telemetry on/off status to turnstile event #3496)instance
bundleId
lat
,lng
from interaction eventsenabled.email
keypushEnabled
an instance methodmap.load
/cc @1ec5 @mapbox/mobiledata @boundsj